You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds ISkillPointService.GetSkillPoints(class, jobLevel), the CP a character can spend on class skills. It gives two CP per job level, plus forty once the character has a class, so a level 80 job ends at 200. The approval table lists every class and job level.
Evidence. The login traces include job level 80 characters. Each one has a lev packet with its remaining CP and a ski packet with its skills. Adding the remaining CP to the CP cost of the active skills listed comes to 200 for every such character. Passive training courses are left out of that sum: with them included, the total is 212. Every traced character is at job level 80, so the slope below the cap is not confirmed. The code comment says so.
This is needed by NosCore #2881, which refuses skill purchases without enough CP and shows the remaining CP in the client.
Added skill point calculations based on character class and job level. Adventurers receive 2 points per job level; other classes receive an additional 40 points.
Documentation
Added tables showing skill point totals across job levels for Adventurers, Swordsmen, Archers, Mages, and Martial Artists.
Two CP per job level, plus forty once the character has a class. Login
traces of job level 80 characters land on 200 CP once their active
skills are paid for.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014gSmkVtYup7KTZ63CJcxZT
No actionable comments were generated in the recent review.
Walkthrough
The pull request adds ISkillPointService and SkillPointService. The service calculates skill points from job level and character class. A documentation test generates a table of values for Adventurer, Swordsman, Archer, Mage, and MartialArtist.
Changes
Skill point calculation
Layer / File(s)
Summary
Service contract and calculation src/NosCore.Algorithm/SkillPointService/ISkillPointService.cs, src/NosCore.Algorithm/SkillPointService/SkillPointService.cs
ISkillPointService defines GetSkillPoints. SkillPointService returns two points per job level, plus 40 points for classes other than Adventurer.
The documentation test generates a table of skill-point values. The approved table covers Adventurer job levels 1–20 and other classes’ job levels 1–80.
This adds a new skill-point lookup service and documents its values. It does not change existing behavior, and no merge-blocking risk was identified.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Add the skill point (CP) curve" matches the main change. The PR adds a skill point service (ISkillPointService and SkillPointService) that computes CP per job level, plus a documentation ta…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Add the skill point (CP) curve" matches the main change. The PR adds a skill point service (ISkillPointService and SkillPointService) that computes CP per job level, plus a documentation table and a test that generates it. The title is short, specific, and names the primary feature.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ISkillPointService.GetSkillPoints(class, jobLevel), the CP a character can spend on class skills. It gives two CP per job level, plus forty once the character has a class, so a level 80 job ends at 200. The approval table lists every class and job level.Evidence. The login traces include job level 80 characters. Each one has a
levpacket with its remaining CP and askipacket with its skills. Adding the remaining CP to the CP cost of the active skills listed comes to 200 for every such character. Passive training courses are left out of that sum: with them included, the total is 212. Every traced character is at job level 80, so the slope below the cap is not confirmed. The code comment says so.This is needed by NosCore #2881, which refuses skill purchases without enough CP and shows the remaining CP in the client.
New feature, so this is a minor bump: 6.4.0.
Generated by Claude Code
Summary by CodeRabbit